Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37948 )
Change subject: mb/google/puff: [WIP] Add power sequencing for LSPCON
......................................................................
Patch Set 2:
I do not have the data sheet for PS175 LSPCON, I have just put the delays arbitrarily. Besides that the FW screens do not appear across warm reset. will have to fix that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37948
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I336d8b72fcd44a0d03ee7f277eb5e838e4005804
Gerrit-Change-Number: 37948
Gerrit-PatchSet: 2
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 28 Dec 2019 07:35:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment