Attention is currently required from: Martin L Roth, Nico Huber.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81290?usp=email )
Change subject: genbuild_h: Fix and harden major/minor version parsing ......................................................................
Patch Set 1:
(2 comments)
File util/genbuild_h/genbuild_h.sh:
https://review.coreboot.org/c/coreboot/+/81290/comment/bb01697f_1ef923e9 : PS1, Line 39: MAJOR_VER="$(echo "${VERSION}" | sed -n 's/^0*([0-9]*).0*([0-9]*).*/\1/p')" : MINOR_VER="$(echo "${VERSION}" | sed -n 's/^0*([0-9]*).0*([0-9]*).*/\2/p')" we could gain some readability if we used extended regex `sed -E` and removed the `` from the characters with special meaning (e.g. '(')
https://review.coreboot.org/c/coreboot/+/81290/comment/c577c3a3_068d9d85 : PS1, Line 40: * nit: we could be more explicit and write {2} instead of * (for year and for month)