Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66605 )
Change subject: mb/google/skyrim: Add missing USB ports to device tree ......................................................................
mb/google/skyrim: Add missing USB ports to device tree
As part of investigating b/240690391 I noticed that we were missing the daughter board ports. Not all SKUs have these ports connected, but it doesn't hurt to have the extra ACPI nodes.
BUG=none TEST=build
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Id6fc34acbfa30bc15e697043bf93bcf584256128 Reviewed-on: https://review.coreboot.org/c/coreboot/+/66605 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jon Murphy jpmurphy@google.com --- M src/mainboard/google/skyrim/variants/skyrim/overridetree.cb 1 file changed, 36 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Jon Murphy: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb index 80bc8ac..945ea19 100644 --- a/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/skyrim/overridetree.cb @@ -40,7 +40,7 @@ register "port_count" = "4" device usb 0.0 on # VL822 USB3 hub chip drivers/usb/acpi - register "desc" = ""USB3 Type-A Port A0 (DB)"" + register "desc" = ""USB3 Type-A Port A0 (MLB)"" register "type" = "UPC_TYPE_USB3_A" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(2, 2))" @@ -57,6 +57,13 @@ register "enable_delay_ms" = "20" device usb 3.1 on end end + chip drivers/usb/acpi + register "desc" = ""USB3 Type-A Port A1 (DB)"" + register "type" = "UPC_TYPE_USB3_A" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, CENTER, ACPI_PLD_GROUP(3, 1))" + device usb 3.2 on end + end end # VL822 USB3 hub end end # USB 3.1 port3 @@ -69,7 +76,7 @@ register "port_count" = "4" device usb 0.0 on # VL822 USB2 hub chip drivers/usb/acpi - register "desc" = ""USB2 Type-A Port A0 (DB)"" + register "desc" = ""USB2 Type-A Port A0 (MLB)"" register "type" = "UPC_TYPE_USB3_A" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(2, 2))" @@ -81,6 +88,13 @@ register "group" = "ACPI_PLD_GROUP(2, 2)" device usb 2.1 on end end + chip drivers/usb/acpi + register "desc" = ""USB2 Type-A Port A1 (DB)"" + register "type" = "UPC_TYPE_USB3_A" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, CENTER, ACPI_PLD_GROUP(3, 1))" + device usb 2.2 on end + end end # VL822 USB2 hub end end # USB 2 port3