Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35922 )
Change subject: mb/intel/kunimitsu: drop support for FSP 1.1
......................................................................
Patch Set 3:
(1 comment)
looks sane and builds; same comments apple here as for glados
https://review.coreboot.org/c/coreboot/+/35922/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35922/3//COMMIT_MSG@18
PS3, Line 18: - add FSP parameter DmiVc1 (see TODO)
: - set FSP board type to "mobile"
:
: TODO:
: - check loadline values again
: - loadline values in devicetree maybe can dropped again, as Maxim is
: working on adding missing loadline values in CB:35167
same comments here as on glados
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35922
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d312ac959a7dac4b018d5ca1d007b1347bcf1dd
Gerrit-Change-Number: 35922
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 09 Oct 2019 21:58:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment