Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33357 )
Change subject: soc/intel/block/cpu: remove unused USE_COREBOOT_NATIVE_MP_INIT ......................................................................
Patch Set 1:
It looks like these Kconfig options poorly reflect what the code does. USE_COREBOOT_NATIVE_MP_INIT is never used in the code,
config USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI bool "Perform MP Initialization by FSP using coreboot MP PPI service" depends on FSP_USES_MP_SERVICES_PPI default y if PLATFORM_USES_FSP2_1 default n select USE_COREBOOT_NATIVE_MP_INIT help This option allows FSP to make use of MP services PPI published by coreboot to perform multiprocessor initialization.
I don't think "USE_COREBOOT_NATIVE_MP_INIT is never used in the code," is true, see original code.
It is selected, but the value is never consumed. Nothing depends on it, no code checks its setting.
so selecting it or not would result in the code attempting to use the native MP init, unless USE_INTEL_FSP_MP_INIT is selected.
It is probably better do drop that option all together.
I agree, please drop USE_COREBOOT_NATIVE_MP_INIT Kconfig first. Then, cleaning up the rest should get easier.