[coreboot-gerrit] New patch to review for coreboot: north/sandybridge: parse rc of flash->write and log the result

[Alexander Couzens]

Alexander Couzens ([e-mail]) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13999

-gerrit

commit 189cc70c23f212ca945b5b6bfc4928c29fe79e38
Author: Alexander Couzens 
Date:   Wed Mar 9 04:02:42 2016 +0100

north/sandybridge: parse rc of flash->write and log the result

Change-Id: I2738da99e4651598faeaa228fba447d0872e9ded
    Signed-off-by: Alexander Couzens 
---
 src/northbridge/intel/sandybridge/mrccache.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/northbridge/intel/sandybridge/mrccache.c b/src/northbridge/intel/sandybridge/mrccache.c
index a5dd456..b5b87ab 100644
--- a/src/northbridge/intel/sandybridge/mrccache.c
+++ b/src/northbridge/intel/sandybridge/mrccache.c
@@ -160,6 +160,7 @@ static void update_mrc_cache(void *unused)
    struct mrc_data_container *current = cbmem_find(CBMEM_ID_MRCDATA);
    struct mrc_data_container *cache, *cache_base;
    u32 cache_size;
+	int ret;

if (!current) {
    	printk(BIOS_ERR, "No MRC cache in cbmem. Can't update flash.\n");
@@ -220,8 +221,13 @@ static void update_mrc_cache(void *unused)
    //  4. write mrc data with flash->write()
    printk(BIOS_DEBUG, "Finally: write MRC cache update to flash at %p\n",
           cache);
-	flash->write(flash, to_flash_offset(flash, cache),
+	ret = flash->write(flash, to_flash_offset(flash, cache),
    	     current->mrc_data_size + sizeof(*current), current);
+	if (ret)
+		printk(BIOS_WARNING, "Writing the MRC cache failed with ret %d\n",
+				ret);
+	else
+		printk(BIOS_DEBUG, "Successful written MRC cache\n");
 }

BOOT_STATE_INIT_ENTRY(BS_WRITE_TABLES, BS_ON_ENTRY, update_mrc_cache, NULL);