Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38770 )
Change subject: Documentation: Add MacBook internal flashing tutorial ......................................................................
Patch Set 1: Code-Review+1
(6 comments)
Nice guide!
https://review.coreboot.org/c/coreboot/+/38770/1/Documentation/flash_tutoria... File Documentation/flash_tutorial/int_macbook.md:
https://review.coreboot.org/c/coreboot/+/38770/1/Documentation/flash_tutoria... PS1, Line 10: an external means `means` is a tricky word. I would have thought it's plural and ommitted the `an`. Not a native speaker, though.
https://review.coreboot.org/c/coreboot/+/38770/1/Documentation/flash_tutoria... PS1, Line 55: permissions permission
https://review.coreboot.org/c/coreboot/+/38770/1/Documentation/flash_tutoria... PS1, Line 152: fdtool ifdtool
https://review.coreboot.org/c/coreboot/+/38770/1/Documentation/flash_tutoria... PS1, Line 176: ROM chip size (1024 KB (1 MB)) Trailing whitespace, and more below...
https://review.coreboot.org/c/coreboot/+/38770/1/Documentation/flash_tutoria... PS1, Line 211: flashrom -p internal -w coreboot8.rom -l new_layout.txt -i bios -N Could do all at once using `-i fd -i me -i bios`. Also, -N shouldn't be necessary.
https://review.coreboot.org/c/coreboot/+/38770/1/Documentation/flash_tutoria... PS1, Line 224: relayout re-layout