Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41884 )
Change subject: drivers/intel/dptf: Add current participant Devices to DSDT
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41884/11/src/drivers/intel/dptf/dpt...
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41884/11/src/drivers/intel/dptf/dpt...
PS11, Line 27: #define DPTF_DPTF_DEVICE_HID "INTC1040"
These new ACPI Device IDs "INTC10xx" are being used for only TigerLake AFAIK at this point. […]
I will add a config option to choose between EISAID (7-char) and the new ones (8-char).
Also the intent is that these _HIDs should not need to be used anywhere else. This file writes the Device objects into the DSDT itself, so no other file/module should need access to the _HID values.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief69a57adce9ee0b19056ce6a11ed8a5b51b3f87
Gerrit-Change-Number: 41884
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jun 2020 17:59:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment