[coreboot-gerrit] [S] Change in coreboot[main]: soc/intel/xeon_sp/skx: Fix CPU init

[Angel Pons (Code Review)]

Attention is currently required from: Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu.

Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85289?usp=email )

Change subject: soc/intel/xeon_sp/skx: Fix CPU init
......................................................................

Patch Set 4: Code-Review+1

(3 comments)

File src/soc/intel/common/block/cpu/cpulib.c:

https://review.coreboot.org/c/coreboot/+/85289/comment/7bc3f02f_a807fdd8?usp... :
PS4, Line 321: CONFIG(SOC_INTEL_APOLLOLAKE) || CONFIG(SOC_INTEL_SKYLAKE) ||
             : 	    CONFIG(SOC_INTEL_KABYLAKE) || CONFIG(SOC_INTEL_BRASWELL) ||
             : 	    CONFIG(SOC_INTEL_BROADWELL) || CONFIG(SOC_INTEL_SKYLAKE_SP)
For another patch: introduce a Kconfig for this

File src/soc/intel/xeon_sp/skx/cpu.c:

https://review.coreboot.org/c/coreboot/+/85289/comment/fb46f7cb_c5ecb4b5?usp... :
PS4, Line 123: 	msr.hi |= BIT20;
Do we know what this does?

https://review.coreboot.org/c/coreboot/+/85289/comment/fc4a96b1_931051ad?usp... :
PS4, Line 153: 	/* Enable Fast Strings */
That's a bit redundant given the macro name, but if this is to bring CPU code closer between Xeon-SP generations I don't mind (can be removed later).