Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44078 )
Change subject: Revert "device/pci_device.c: Do not complain about disabled devices" ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44078/1/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/44078/1/src/device/pci_device.c@128... PS1, Line 1280: /* : * Warn if any leftover static devices are are found. : * There's probably a problem in devicetree.cb. : */ : : prev = &bus->children; : for (dev = bus->children; dev; dev = dev->sibling) { : /* : * The device is only considered leftover if it is not hidden : * and it has a Vendor ID of 0 (the default for a device that : * could not be probed). : */ : if (dev->vendor != 0 || dev->hidden) { : prev = &dev->sibling; : continue; : } : : /* Unlink it from list. */ : *prev = dev->sibling; : : if (!once++) : printk(BIOS_WARNING, "PCI: Leftover static devices:\n"); : printk(BIOS_WARNING, "%s\n", dev_path(dev)); : } : : if (once) : printk(BIOS_WARNING, "PCI: Check your devicetree.cb.\n"); Then this whole thing needs to be elsewhere, right?