[coreboot-gerrit] Change in coreboot[master]: mb/amd/{bilby,mandolin}: Turn empty `chip` entry into comment

[Nico Huber (Code Review)]

Attention is currently required from: Felix Held.
Hello Felix Held,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/57430

to review the following change.

Change subject: mb/amd/{bilby,mandolin}: Turn empty `chip` entry into comment
......................................................................

mb/amd/{bilby,mandolin}: Turn empty `chip` entry into comment

A chip entry in the devicetree is not hooked up without a device
beneath it. It seems the intention was to leave these superio
drivers unconfigured, so there should be no harm to turn the
entries into comments.

Change-Id: I6b606f35eba089b74c562084772d95be41cac39c
Signed-off-by: Nico Huber 
---
M src/mainboard/amd/bilby/devicetree.cb
M src/mainboard/amd/mandolin/variants/cereme/devicetree.cb
M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
3 files changed, 3 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/57430/1

diff --git a/src/mainboard/amd/bilby/devicetree.cb b/src/mainboard/amd/bilby/devicetree.cb
index c089d0d..aaf1c3b 100644
--- a/src/mainboard/amd/bilby/devicetree.cb
+++ b/src/mainboard/amd/bilby/devicetree.cb
@@ -160,8 +160,7 @@
    		device ref xgbe_1 off end # integrated Ethernet MAC
    	end
    	device ref lpc_bridge on
-			chip superio/smsc/sio1036 # optional debug card
-			end
+			# chip superio/smsc/sio1036 # optional debug card
    	end
    end # domain

diff --git a/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb b/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb
index dbb1a14..6342c29 100644
--- a/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb
+++ b/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb
@@ -149,8 +149,7 @@
    		device ref xgbe_1 off end # integrated Ethernet MAC
    	end
    	device ref lpc_bridge on
-			chip superio/smsc/sio1036 # optional debug card
-			end
+			# chip superio/smsc/sio1036 # optional debug card
    	end
    end # domain

diff --git a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
index 6b5a60b..035bb70 100644
--- a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
+++ b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
@@ -149,8 +149,7 @@
    		device ref xgbe_1 off end # integrated Ethernet MAC
    	end
    	device ref lpc_bridge on
-			chip superio/smsc/sio1036 # optional debug card
-			end
+			# chip superio/smsc/sio1036 # optional debug card
    	end
    end # domain