Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37863 )
Change subject: mb/intel/tglrvp : Enable MIPI Camera ......................................................................
Patch Set 7:
(6 comments)
https://review.coreboot.org/c/coreboot/+/37863/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37863/7//COMMIT_MSG@7 PS7, Line 7: nit: remove space
https://review.coreboot.org/c/coreboot/+/37863/7//COMMIT_MSG@9 PS7, Line 9: Enable MIPI Camera remove - redundant with subject line
https://review.coreboot.org/c/coreboot/+/37863/7//COMMIT_MSG@15 PS7, Line 15: check Camera check camera how?
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/... PS7, Line 4: 2019 2020
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/... PS7, Line 68: c nit: capital "C" to be consistent with other comments
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c:
https://review.coreboot.org/c/coreboot/+/37863/7/src/mainboard/intel/tglrvp/... PS7, Line 29: Why is there a blank line here? If there's a reason for separating lines 30 and 31 from other camera configs on line 27 and 28, please add comment as to what it is. Otherwise, please remove line 29.