Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Eric Lai.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64089 )
Change subject: intelblocks: Add function to enable GPE
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64089/comment/f0d5d3e5_69ae945f
PS2, Line 9: was
Present tense: is
https://review.coreboot.org/c/coreboot/+/64089/comment/0870e067_aa867839
PS2, Line 18: which are capable of generating SCI.
Could be shortened to:
… capable of generating SCI.
https://review.coreboot.org/c/coreboot/+/64089/comment/38d09919_edcf8d82
PS2, Line 20: This will help resolve issue where we don't see wake event GPIO in event
: log.
I always like an issue description in the beginning too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27e525f50c374c2cc9675e77eaa7774683a6e7c2
Gerrit-Change-Number: 64089
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 06 May 2022 10:34:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment