[coreboot-gerrit] Change in coreboot[master]: {drivers,mainboard}: Move FSP logo support to fsp1_1

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36679 )

Change subject: {drivers,mainboard}: Move FSP logo support to fsp1_1
......................................................................

Patch Set 12: Code-Review+1

(1 comment)

I'm not so sure how removing things from cbmem works. Can you confirm the space is not taken anymore?

https://review.coreboot.org/c/coreboot/+/36679/10/src/drivers/intel/fsp1_1/r... 
File src/drivers/intel/fsp1_1/ramstage.c:

https://review.coreboot.org/c/coreboot/+/36679/10/src/drivers/intel/fsp1_1/r... 
PS10, Line 124: if (CONFIG(FSP1_1_DISPLAY_LOGO) && !is_s3_wakeup)
              : 		cbmem_entry_remove(logo_entry);
It's pretty obvious to me, but it might be worth commenting here that the image is now in a framebuffer and not needed in coreboot anymore so it can be removed to save up space.