Attention is currently required from: Deepti Deshatty, Li Feng, Li1 Feng, Subrata Banik, V Sowmya.
Varun Upadhyay has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/83656?usp=email )
Change subject: mb/google/trulo/var/orisa: Update ISH GPIO's configuration
......................................................................
Patch Set 3:
(2 comments)
This change is ready for review.
Patchset:
PS2:
your patch needs rebasing as the underlying coreboot code had changed since you forked it.
Done
File src/mainboard/google/brya/variants/orisa/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83656/comment/68d25aff_fcd32671?usp... :
PS2, Line 527: orisa_ish
can we have generic name w/o associating any platform ? if you wish to attach a platform name, then […]
i have removed the firmware name config for the Orisa. Just keeping the GPIO's changes in this patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83656?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I24745ba629c59c092ce676b29915e356a4d8d8af
Gerrit-Change-Number: 83656
Gerrit-PatchSet: 3
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Li Feng
li1.feng@intel.corp-partner.google.com
Gerrit-Reviewer: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Li Feng
li1.feng@intel.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Comment-Date: Thu, 01 Aug 2024 06:30:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com