build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32407 )
Change subject: soc/amd/picasso: Create picasso as a copy of stoneyridge ......................................................................
Patch Set 2:
(11 comments)
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/bootblock/bootbl... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/bootblock/bootbl... PS2, Line 83: void (*ap_romstage_entry)(void) = function definition argument 'void' should also have an identifier name
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/include/soc/sout... File src/soc/amd/picasso/include/soc/southbridge.h:
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/include/soc/sout... PS2, Line 265: #define SPI_READ_MODE_DUAL112 ( BIT(29) ) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/include/soc/sout... PS2, Line 265: #define SPI_READ_MODE_DUAL112 ( BIT(29) ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/include/soc/sout... PS2, Line 266: #define SPI_READ_MODE_QUAD114 ( BIT(29) | BIT(18)) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/include/soc/sout... PS2, Line 267: #define SPI_READ_MODE_DUAL122 (BIT(30) ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/include/soc/sout... PS2, Line 269: #define SPI_READ_MODE_NORMAL66 (BIT(30) | BIT(29) ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/include/soc/sout... PS2, Line 296: #define SPI_SPEED_33M ( BIT(0)) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/include/soc/sout... PS2, Line 297: #define SPI_SPEED_22M ( BIT(1) ) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/include/soc/sout... PS2, Line 297: #define SPI_SPEED_22M ( BIT(1) ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/include/soc/sout... PS2, Line 298: #define SPI_SPEED_16M ( BIT(1) | BIT(0)) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/32407/2/src/soc/amd/picasso/include/soc/sout... PS2, Line 299: #define SPI_SPEED_100M (BIT(2) ) space prohibited before that close parenthesis ')'