View Change

11 comments:

• File src/soc/amd/picasso/bootblock/bootblock.c:

  • Patch Set #2, Line 83: void (*ap_romstage_entry)(void) =

    function definition argument 'void' should also have an identifier name

• File src/soc/amd/picasso/include/soc/southbridge.h:

  • Patch Set #2, Line 265: #define SPI_READ_MODE_DUAL112 ( BIT(29) )

    space prohibited after that open parenthesis '('

  • Patch Set #2, Line 265: #define SPI_READ_MODE_DUAL112 ( BIT(29) )

    space prohibited before that close parenthesis ')'

  • Patch Set #2, Line 266: #define SPI_READ_MODE_QUAD114 ( BIT(29) | BIT(18))

    space prohibited after that open parenthesis '('

  • Patch Set #2, Line 267: #define SPI_READ_MODE_DUAL122 (BIT(30) )

    space prohibited before that close parenthesis ')'

  • Patch Set #2, Line 269: #define SPI_READ_MODE_NORMAL66 (BIT(30) | BIT(29) )

    space prohibited before that close parenthesis ')'

  • Patch Set #2, Line 296: #define SPI_SPEED_33M ( BIT(0))

    space prohibited after that open parenthesis '('

  • Patch Set #2, Line 297: #define SPI_SPEED_22M ( BIT(1) )

    space prohibited after that open parenthesis '('

  • Patch Set #2, Line 297: #define SPI_SPEED_22M ( BIT(1) )

    space prohibited before that close parenthesis ')'

  • Patch Set #2, Line 298: #define SPI_SPEED_16M ( BIT(1) | BIT(0))

    space prohibited after that open parenthesis '('

  • Patch Set #2, Line 299: #define SPI_SPEED_100M (BIT(2) )

    space prohibited before that close parenthesis ')'

To view, visit change 32407. To unsubscribe, or for help writing mail filters, visit settings.