9 Dec
2020
9 Dec
'20
4:06 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47599 )
Change subject: arch/x86: Move prologue to .init section ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47599/7/src/soc/amd/common/block/cp... File src/soc/amd/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/47599/7/src/soc/amd/common/block/cp... PS7, Line 16: _cache_as_ram_setup_end
I assume this is .globl only to match drivers/amd/agesa/cache_as_ram. […]
Should be no need for .global here either.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47599
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If32518b1c19d08935727330314904b52a246af3c
Gerrit-Change-Number: 47599
Gerrit-PatchSet: 9
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Huang Jin huang.jin@intel.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Lee Leahy leroy.p.leahy@intel.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Dec 2020 11:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-MessageType: comment