Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41734 )
Change subject: soc/amd/picasso/Makefile: Change APCB_magic.bin location
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
i wonder if we should wait with submitting this until the blob is merged and the submodule pointer is updated
Either or, it doesn't build upstream currently, so not sure it matters.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib082a8e7fc631ca7145b0b77e49ea0cbf99dff41
Gerrit-Change-Number: 41734
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Tue, 26 May 2020 17:45:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment