20 Feb
2019
20 Feb
'19
10:26 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31524 )
Change subject: timestamp: Move timestamp_should_run() call ......................................................................
Patch Set 1: Code-Review+1
LGTM but I'm not really familiar with the need for timestamp_should_run().
That implementation of get_us_since_boot() should not depend on COLLECT_TIMESTAMPS. Maybe it could be somehere in TSC/APIC/MONOTONIC_TIMER instead?
That seems somewhat difficult... I don't think you can provide that (at least implemented the way it is now) without pulling in most of the timestamp code anyway.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31524
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice9ece11b15bbe1a58a038cda3d299862e6f822b
Gerrit-Change-Number: 31524
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@google.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 Feb 2019 21:26:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment