27 Aug
2019
27 Aug
'19
8:45 p.m.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35113 )
Change subject: mb/google/drallion: add dummy SPD file ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35113/2/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/arcada_cml/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35113/2/src/mainboard/google/dralli... PS2, Line 17: SPD_SOURCES = empty_ddr4 # 0b00000
soldered down memory is not planned for arcada_cml and sarien_cml, do we really to update these 2 va […]
we need dummy one anyway.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35113
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife59c2dd689d72b117f30e832a3ce7eed4fa4220
Gerrit-Change-Number: 35113
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 28 Aug 2019 03:45:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Selma Bensaid selma.bensaid@intel.com
Gerrit-MessageType: comment