Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45404 )
Change subject: src: Include <arch/io.h> when appropriate ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45404/3/src/drivers/ipmi/ipmi_kcs_o... File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/45404/3/src/drivers/ipmi/ipmi_kcs_o... PS3, Line 11: #include <arch/io.h>
this isn't what the commit message says. […]
Done
https://review.coreboot.org/c/coreboot/+/45404/4/src/mainboard/asus/a88xm-e/... File src/mainboard/asus/a88xm-e/romstage.c:
https://review.coreboot.org/c/coreboot/+/45404/4/src/mainboard/asus/a88xm-e/... PS4, Line 9: post_code(0x30); unrelated to this patch, but the header for this is probably missing
https://review.coreboot.org/c/coreboot/+/45404/4/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/romstage.c:
https://review.coreboot.org/c/coreboot/+/45404/4/src/mainboard/asus/f2a85-m/... PS4, Line 12: post_code(0x30); same here