build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37874 )
Change subject: soc/intel/cannonlake: Add VR config for CML ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37874/1/src/soc/intel/cannonlake/vr... File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/37874/1/src/soc/intel/cannonlake/vr... PS1, Line 283: icc_max[VR_IA_CORE] = VR_CFG_AMP(86); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37874/1/src/soc/intel/cannonlake/vr... PS1, Line 283: icc_max[VR_IA_CORE] = VR_CFG_AMP(86); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37874/1/src/soc/intel/cannonlake/vr... PS1, Line 312: if (tdp >= 65) /* 125W or 80W or 65W */ suspect code indent for conditional statements (16, 32)