[coreboot-gerrit] [S] Change in coreboot[main]: cpu/intel/car/romstage: Fix false-positive stack corruption

[Angel Pons (Code Review)]

Attention is currently required from: Christian Walter, Jincheng Li, Jérémy Compostella, Patrick Rudolph, Subrata Banik, Uwe Poeche, [e-mail].

Angel Pons has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85568?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: cpu/intel/car/romstage: Fix false-positive stack corruption
......................................................................

Patch Set 3: Code-Review+2

(3 comments)

File src/cpu/intel/car/romstage.c:

https://review.coreboot.org/c/coreboot/+/85568/comment/5c8badf4_0a2a553a?usp... :
PS3, Line 45: behviour
typo:

```suggestion
     * (and thus hard to debug) behaviour.
```

https://review.coreboot.org/c/coreboot/+/85568/comment/da8f0a6d_40f8b5b3?usp... :
PS3, Line 47: serve 
typo?

```suggestion	 * severe and allowed romstage to run. It's useful to detect problems when
```

https://review.coreboot.org/c/coreboot/+/85568/comment/92343a72_e78ada0a?usp... :
PS3, Line 50:  * When HW breakpoints are used and enabled the stack canary breakpoint will
            : 	 * report the instruction pointer immediately and thus gives hint which function
            : 	 * does use too much stack. FSP might disable HW breakpoints though.
nit: some grammar fixes and a bit of rewording

```suggestion
     * When HW breakpoints are used and enabled, the stack canary breakpoint will
     * reports the instruction pointer immediately, which can hint at which function
     * may be using too much stack. FSP might disable HW breakpoints, though.
```