Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39919 )
Change subject: mb/google/slippy: Convert variants to use override devicetree
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39919/1/src/mainboard/google/slippy...
File src/mainboard/google/slippy/variants/falco/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39919/1/src/mainboard/google/slippy...
PS1, Line 4: register "gpu_panel_port_select" = "1" # eDP
cleaner just to keep the entire panel section together IMO
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If237fad38a1bccfb8e51edfae3ecb75d05ade240
Gerrit-Change-Number: 39919
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 30 Mar 2020 19:17:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment