Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39459 )
Change subject: soc/intel/tigerlake: Configure IOM_TYPEC_SW_CONFIGURATION_3 ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39459/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39459/7//COMMIT_MSG@9 PS7, Line 9: FSP UPD TcssAuxOri is used for setting the IOM_TYPEC_SW_CONFIGURATION_3
Please add a dot/period at the end of sentences.
Done
https://review.coreboot.org/c/coreboot/+/39459/7//COMMIT_MSG@15 PS7, Line 15: ports the
… ports. […]
Done
https://review.coreboot.org/c/coreboot/+/39459/7//COMMIT_MSG@22 PS7, Line 22: Type-c
Type-C
Done
https://review.coreboot.org/c/coreboot/+/39459/7//COMMIT_MSG@22 PS7, Line 22: Type-c
Type-C
Done
https://review.coreboot.org/c/coreboot/+/39459/7/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/39459/7/src/soc/intel/tigerlake/chi... PS7, Line 239: * on the motherboard.
Please format this as a list.
what kind of list are you thinking there is no point listing out the entire bitfield here as it is described in the EDS