Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32023 )
Change subject: src: Use 'include <stdlib.h>' when appropriate ......................................................................
Patch Set 8: Code-Review+1
(132 comments)
A bunch of "{add, remove} extra newline are optional and are up to you. You cann add it to the cimmit message if you decide to modify the newlines if you like.
https://review.coreboot.org/#/c/32023/8/src/commonlib/region.c File src/commonlib/region.c:
https://review.coreboot.org/#/c/32023/8/src/commonlib/region.c@19 PS8, Line 19: #include <stdlib.h> Try to add includes in an alphabetical order.
https://review.coreboot.org/#/c/32023/8/src/commonlib/storage/bouncebuf.c File src/commonlib/storage/bouncebuf.c:
https://review.coreboot.org/#/c/32023/8/src/commonlib/storage/bouncebuf.c@20 PS8, Line 20: #include <string.h> : #include <stdlib.h> same here
https://review.coreboot.org/#/c/32023/8/src/commonlib/storage/sdhci_adma.c File src/commonlib/storage/sdhci_adma.c:
https://review.coreboot.org/#/c/32023/8/src/commonlib/storage/sdhci_adma.c@2... PS8, Line 26: #include <stdlib.h> same here
https://review.coreboot.org/#/c/32023/8/src/cpu/x86/lapic/lapic_cpu_init.c File src/cpu/x86/lapic/lapic_cpu_init.c:
https://review.coreboot.org/#/c/32023/8/src/cpu/x86/lapic/lapic_cpu_init.c@3... PS8, Line 38: #include <stdlib.h> and here
https://review.coreboot.org/#/c/32023/8/src/device/device_util.c File src/device/device_util.c:
https://review.coreboot.org/#/c/32023/8/src/device/device_util.c@27 PS8, Line 27: #include <stdlib.h> same
https://review.coreboot.org/#/c/32023/8/src/drivers/i2c/tpm/tis_atmel.c File src/drivers/i2c/tpm/tis_atmel.c:
https://review.coreboot.org/#/c/32023/8/src/drivers/i2c/tpm/tis_atmel.c@26 PS8, Line 26: #include <stdlib.h> and here
https://review.coreboot.org/#/c/32023/8/src/drivers/spi/spi-generic.c File src/drivers/spi/spi-generic.c:
https://review.coreboot.org/#/c/32023/8/src/drivers/spi/spi-generic.c@20 PS8, Line 20: #include <stdlib.h> and here
https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/serengeti_cheetah_... File src/mainboard/amd/serengeti_cheetah_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/serengeti_cheetah_... PS8, Line 21: Should we get rind of this extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/tilapia_fam10/get_... File src/mainboard/amd/tilapia_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/tilapia_fam10/get_... PS8, Line 19: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/torpedo/BiosCallOu... File src/mainboard/amd/torpedo/BiosCallOuts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/torpedo/BiosCallOu... PS8, Line 19: #include "Hudson-2.h" Once touching this file move this include down?
https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/union_station/buil... File src/mainboard/amd/union_station/buildOpts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/union_station/buil... PS8, Line 28: delete these two newlines?
https://review.coreboot.org/#/c/32023/8/src/mainboard/asrock/e350m1/buildOpt... File src/mainboard/asrock/e350m1/buildOpts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/asrock/e350m1/buildOpt... PS8, Line 29: One newline should be good enough.
https://review.coreboot.org/#/c/32023/8/src/mainboard/asus/m4a78-em/get_bus_... File src/mainboard/asus/m4a78-em/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/asus/m4a78-em/get_bus_... PS8, Line 19: delete extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/asus/m4a785-m/get_bus_... File src/mainboard/asus/m4a785-m/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/asus/m4a785-m/get_bus_... PS8, Line 19: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/mainboard/elmex/pcm205400/buildO... File src/mainboard/elmex/pcm205400/buildOpts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/elmex/pcm205400/buildO... PS8, Line 28: delete 2 extra newlines here?
https://review.coreboot.org/#/c/32023/8/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/emulation/qemu-i440fx/... PS8, Line 16: #include <stdlib.h> Try to add includes in an alphabetical order.
https://review.coreboot.org/#/c/32023/8/src/mainboard/gigabyte/ma785gm/get_b... File src/mainboard/gigabyte/ma785gm/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/gigabyte/ma785gm/get_b... PS8, Line 19: delete extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/gigabyte/ma78gm/get_bu... File src/mainboard/gigabyte/ma78gm/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/gigabyte/ma78gm/get_bu... PS8, Line 19: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/mainboard/gizmosphere/gizmo/buil... File src/mainboard/gizmosphere/gizmo/buildOpts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/gizmosphere/gizmo/buil... PS8, Line 29: get rid of extra newlines?
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/beltino/variant... File src/mainboard/google/beltino/variants/mccloud/hda_verb.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/beltino/variant... PS8, Line 19: delete extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/beltino/variant... File src/mainboard/google/beltino/variants/monroe/hda_verb.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/beltino/variant... PS8, Line 19: here, too
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/beltino/variant... File src/mainboard/google/beltino/variants/panther/hda_verb.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/beltino/variant... PS8, Line 19: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/beltino/variant... File src/mainboard/google/beltino/variants/tricky/hda_verb.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/beltino/variant... PS8, Line 19: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/beltino/variant... File src/mainboard/google/beltino/variants/zako/hda_verb.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/beltino/variant... PS8, Line 19: here, too
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/cyan/variants/k... File src/mainboard/google/cyan/variants/kefka/gpio.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/cyan/variants/k... PS8, Line 19: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/cyan/variants/r... File src/mainboard/google/cyan/variants/relm/gpio.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/cyan/variants/r... PS8, Line 19: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/cyan/variants/s... File src/mainboard/google/cyan/variants/setzer/gpio.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/cyan/variants/s... PS8, Line 19: here, too
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/urara/boardid.c File src/mainboard/google/urara/boardid.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/google/urara/boardid.c... PS8, Line 18: delete extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/hp/dl165_g6_fam10/get_... File src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/hp/dl165_g6_fam10/get_... PS8, Line 24: delete extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/hp/pavilion_m6_1035dx/... File src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/hp/pavilion_m6_1035dx/... PS8, Line 19: delete extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/intel/kblrvp/mainboard... File src/mainboard/intel/kblrvp/mainboard.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/intel/kblrvp/mainboard... PS8, Line 23: #include "ec.h" move this include to the last position?
https://review.coreboot.org/#/c/32023/8/src/mainboard/intel/kunimitsu/mainbo... File src/mainboard/intel/kunimitsu/mainboard.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/intel/kunimitsu/mainbo... PS8, Line 23: #include <vendorcode/google/chromeos/chromeos.h> add extra newline here?
https://review.coreboot.org/#/c/32023/8/src/mainboard/intel/strago/gpio.c File src/mainboard/intel/strago/gpio.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/intel/strago/gpio.c@19 PS8, Line 19: #include <boardid.h> add extra newline here?
https://review.coreboot.org/#/c/32023/8/src/mainboard/jetway/nf81-t56n-lf/Bi... File src/mainboard/jetway/nf81-t56n-lf/BiosCallOuts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/jetway/nf81-t56n-lf/Bi... PS8, Line 18: delete extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/jetway/nf81-t56n-lf/bu... File src/mainboard/jetway/nf81-t56n-lf/buildOpts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/jetway/nf81-t56n-lf/bu... PS8, Line 28: delete extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/jetway/pa78vm5/get_bus... File src/mainboard/jetway/pa78vm5/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/jetway/pa78vm5/get_bus... PS8, Line 19: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/mainboard/lenovo/g505s/BiosCallO... File src/mainboard/lenovo/g505s/BiosCallOuts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/lenovo/g505s/BiosCallO... PS8, Line 19: here, too
https://review.coreboot.org/#/c/32023/8/src/mainboard/lenovo/g505s/buildOpts... File src/mainboard/lenovo/g505s/buildOpts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/lenovo/g505s/buildOpts... PS8, Line 29: delete extra newlines
https://review.coreboot.org/#/c/32023/8/src/mainboard/lippert/frontrunner-af... File src/mainboard/lippert/frontrunner-af/buildOpts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/lippert/frontrunner-af... PS8, Line 28: delete extra newlines
https://review.coreboot.org/#/c/32023/8/src/mainboard/lippert/frontrunner-af... File src/mainboard/lippert/frontrunner-af/sema.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/lippert/frontrunner-af... PS8, Line 19: move this newline before local includes?
https://review.coreboot.org/#/c/32023/8/src/mainboard/lippert/toucan-af/buil... File src/mainboard/lippert/toucan-af/buildOpts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/lippert/toucan-af/buil... PS8, Line 28: delete extra newlines
https://review.coreboot.org/#/c/32023/8/src/mainboard/msi/ms7721/BiosCallOut... File src/mainboard/msi/ms7721/BiosCallOuts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/msi/ms7721/BiosCallOut... PS8, Line 20: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/mainboard/msi/ms7721/buildOpts.c File src/mainboard/msi/ms7721/buildOpts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/msi/ms7721/buildOpts.c... PS8, Line 28: here, too
https://review.coreboot.org/#/c/32023/8/src/mainboard/msi/ms9652_fam10/get_b... File src/mainboard/msi/ms9652_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/msi/ms9652_fam10/get_b... PS8, Line 24: delete this newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/pcengines/apu1/BiosCal... File src/mainboard/pcengines/apu1/BiosCallOuts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/pcengines/apu1/BiosCal... PS8, Line 20: #include "gpio_ftns.h" add extra newline before local includes.
https://review.coreboot.org/#/c/32023/8/src/mainboard/pcengines/apu1/buildOp... File src/mainboard/pcengines/apu1/buildOpts.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/pcengines/apu1/buildOp... PS8, Line 28: delete extra newlines
https://review.coreboot.org/#/c/32023/8/src/mainboard/roda/rk886ex/m3885.c File src/mainboard/roda/rk886ex/m3885.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/roda/rk886ex/m3885.c@2... PS8, Line 21: move this newline right before local include?
https://review.coreboot.org/#/c/32023/8/src/mainboard/supermicro/h8dmr_fam10... File src/mainboard/supermicro/h8dmr_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/supermicro/h8dmr_fam10... PS8, Line 24: delete extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/supermicro/h8qme_fam10... File src/mainboard/supermicro/h8qme_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/supermicro/h8qme_fam10... PS8, Line 24: delete extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/supermicro/h8scm_fam10... File src/mainboard/supermicro/h8scm_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/supermicro/h8scm_fam10... PS8, Line 20: delete extra newline?
https://review.coreboot.org/#/c/32023/8/src/mainboard/tyan/s2912_fam10/get_b... File src/mainboard/tyan/s2912_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/32023/8/src/mainboard/tyan/s2912_fam10/get_b... PS8, Line 24: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/northbridge/amd/agesa/family12/d... File src/northbridge/amd/agesa/family12/dimmSpd.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/amd/agesa/family12/d... PS8, Line 32: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/northbridge/amd/agesa/family12/n... File src/northbridge/amd/agesa/family12/northbridge.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/amd/agesa/family12/n... PS8, Line 28: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/northbridge/amd/agesa/family14/d... File src/northbridge/amd/agesa/family14/dimmSpd.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/amd/agesa/family14/d... PS8, Line 19: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/northbridge/amd/agesa/family14/d... PS8, Line 23: #include "chip.h" move local include to the last position?
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/haswell/early_... File src/northbridge/intel/haswell/early_init.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/haswell/early_... PS8, Line 23: #include "haswell.h" add extra newline?
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/haswell/finali... File src/northbridge/intel/haswell/finalize.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/haswell/finali... PS8, Line 17: #include <device/pci_ops.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/i440bx/northbr... File src/northbridge/intel/i440bx/northbridge.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/i440bx/northbr... PS8, Line 20: #include <cpu/cpu.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/i440bx/raminit... File src/northbridge/intel/i440bx/raminit.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/i440bx/raminit... PS8, Line 24: #include <console/console.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/i945/early_ini... File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/i945/early_ini... PS8, Line 24: #include "i945.h move this local include to the last position?
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/i945/northbrid... File src/northbridge/intel/i945/northbridge.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/i945/northbrid... PS8, Line 25: #include <cpu/intel/smm/gen1/smi.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/nehalem/finali... File src/northbridge/intel/nehalem/finalize.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/nehalem/finali... PS8, Line 17: #include <device/pci_ops.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/nehalem/northb... File src/northbridge/intel/nehalem/northbridge.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/nehalem/northb... PS8, Line 29: #include "chip.h" : #include "nehalem.h" once touching it move local includes down?
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/sandybridge/fi... File src/northbridge/intel/sandybridge/finalize.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/sandybridge/fi... PS8, Line 17: #include <device/pci_ops.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/sandybridge/no... File src/northbridge/intel/sandybridge/northbridge.c:
https://review.coreboot.org/#/c/32023/8/src/northbridge/intel/sandybridge/no... PS8, Line 28: #include "chip.h" : #include "sandybridge.h" move local includes down?
https://review.coreboot.org/#/c/32023/8/src/security/tpm/tss/tcg-2.0/tss_mar... File src/security/tpm/tss/tcg-2.0/tss_marshaling.c:
https://review.coreboot.org/#/c/32023/8/src/security/tpm/tss/tcg-2.0/tss_mar... PS8, Line 12: #include "tss_marshaling.h" move local include down?
https://review.coreboot.org/#/c/32023/8/src/soc/amd/stoneyridge/BiosCallOuts... File src/soc/amd/stoneyridge/BiosCallOuts.c:
https://review.coreboot.org/#/c/32023/8/src/soc/amd/stoneyridge/BiosCallOuts... PS8, Line 26: #include "chip.h" move local include down and adjust newlines?
https://review.coreboot.org/#/c/32023/8/src/soc/intel/baytrail/ramstage.c File src/soc/intel/baytrail/ramstage.c:
https://review.coreboot.org/#/c/32023/8/src/soc/intel/baytrail/ramstage.c@27 PS8, Line 27: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/soc/intel/common/acpi_wake_sourc... File src/soc/intel/common/acpi_wake_source.c:
https://review.coreboot.org/#/c/32023/8/src/soc/intel/common/acpi_wake_sourc... PS8, Line 21: #include <stdint.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/soc/intel/common/smbios.c File src/soc/intel/common/smbios.c:
https://review.coreboot.org/#/c/32023/8/src/soc/intel/common/smbios.c@17 PS8, Line 17: #include "smbios.h" move local include down?
https://review.coreboot.org/#/c/32023/8/src/soc/intel/denverton_ns/systemage... File src/soc/intel/denverton_ns/systemagent.c:
https://review.coreboot.org/#/c/32023/8/src/soc/intel/denverton_ns/systemage... PS8, Line 27: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/soc/intel/fsp_baytrail/ramstage.... File src/soc/intel/fsp_baytrail/ramstage.c:
https://review.coreboot.org/#/c/32023/8/src/soc/intel/fsp_baytrail/ramstage.... PS8, Line 27: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/soc/intel/fsp_baytrail/smihandle... File src/soc/intel/fsp_baytrail/smihandler.c:
https://review.coreboot.org/#/c/32023/8/src/soc/intel/fsp_baytrail/smihandle... PS8, Line 25: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/soc/nvidia/tegra/i2c.c File src/soc/nvidia/tegra/i2c.c:
https://review.coreboot.org/#/c/32023/8/src/soc/nvidia/tegra/i2c.c@21 PS8, Line 21: #include <soc/addressmap.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/soc/nvidia/tegra210/dc.c File src/soc/nvidia/tegra210/dc.c:
https://review.coreboot.org/#/c/32023/8/src/soc/nvidia/tegra210/dc.c@21 PS8, Line 21: #include "chip.h" move local include down?
https://review.coreboot.org/#/c/32023/8/src/soc/nvidia/tegra210/dsi.c File src/soc/nvidia/tegra210/dsi.c:
https://review.coreboot.org/#/c/32023/8/src/soc/nvidia/tegra210/dsi.c@26 PS8, Line 26: #include "chip.h" move local include down?
https://review.coreboot.org/#/c/32023/8/src/soc/nvidia/tegra210/jdi_25x18_di... File src/soc/nvidia/tegra210/jdi_25x18_display/panel-jdi-lpm102a188a.c:
https://review.coreboot.org/#/c/32023/8/src/soc/nvidia/tegra210/jdi_25x18_di... PS8, Line 22: #include "../chip.h" move local include down?
https://review.coreboot.org/#/c/32023/8/src/soc/nvidia/tegra210/jdi_25x18_di... PS8, Line 25: #include <soc/tegra_dsi.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/soc/nvidia/tegra210/mipi.c File src/soc/nvidia/tegra210/mipi.c:
https://review.coreboot.org/#/c/32023/8/src/soc/nvidia/tegra210/mipi.c@27 PS8, Line 27: #include <soc/tegra_dsi.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/agesa/hudson/sm.... File src/southbridge/amd/agesa/hudson/sm.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/agesa/hudson/sm.... PS8, Line 22: #include <arch/ioapic.h> add extra newlines
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/agesa/hudson/spi... File src/southbridge/amd/agesa/hudson/spi.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/agesa/hudson/spi... PS8, Line 23: delete extra newline
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/cimx/sb800/spi.c File src/southbridge/amd/cimx/sb800/spi.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/cimx/sb800/spi.c... PS8, Line 24: #include "SBPLATFORM.h" move local include down?
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/pi/hudson/sm.c File src/southbridge/amd/pi/hudson/sm.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/pi/hudson/sm.c@2... PS8, Line 22: #include <arch/ioapic.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/sb700/sm.c File src/southbridge/amd/sb700/sm.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/sb700/sm.c@26 PS8, Line 26: #include <arch/ioapic.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/sb800/sm.c File src/southbridge/amd/sb800/sm.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/sb800/sm.c@25 PS8, Line 25: #include <arch/ioapic.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/bd82x6x/me_sta... File src/southbridge/intel/bd82x6x/me_status.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/bd82x6x/me_sta... PS8, Line 17: #include <console/console.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/common/smbus.c File src/southbridge/intel/common/smbus.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/common/smbus.c... PS8, Line 20: #include <device/smbus_def.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/fsp_rangeley/e... File src/southbridge/intel/fsp_rangeley/early_init.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/fsp_rangeley/e... PS8, Line 25: #include <version.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/i82801ix/i8280... File src/southbridge/intel/i82801ix/i82801ix.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/i82801ix/i8280... PS8, Line 23: #include <console/console.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/i82801jx/i8280... File src/southbridge/intel/i82801jx/i82801jx.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/i82801jx/i8280... PS8, Line 23: #include <console/console.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/lynxpoint/me_s... File src/southbridge/intel/lynxpoint/me_status.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/lynxpoint/me_s... PS8, Line 17: #include <console/console.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/lynxpoint/seri... File src/southbridge/intel/lynxpoint/serialio.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/intel/lynxpoint/seri... PS8, Line 23: #include <device/pci_ids.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/southbridge/nvidia/ck804/lpc.c File src/southbridge/nvidia/ck804/lpc.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/nvidia/ck804/lpc.c@3... PS8, Line 33: #include <cpu/amd/powernow.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/southbridge/nvidia/mcp55/lpc.c File src/southbridge/nvidia/mcp55/lpc.c:
https://review.coreboot.org/#/c/32023/8/src/southbridge/nvidia/mcp55/lpc.c@3... PS8, Line 34: #include <cpu/amd/powernow.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/superio/fintek/f71805f/superio.c File src/superio/fintek/f71805f/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/fintek/f71805f/superio.c... PS8, Line 19: #include <superio/conf_mode.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/fintek/f71863fg/superio.... File src/superio/fintek/f71863fg/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/fintek/f71863fg/superio.... PS8, Line 20: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/fintek/f71872/superio.c File src/superio/fintek/f71872/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/fintek/f71872/superio.c@... PS8, Line 20: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/fintek/f81865f/superio.c File src/superio/fintek/f81865f/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/fintek/f81865f/superio.c... PS8, Line 20: #include <pc80/keyboard.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/superio/fintek/f81866d/superio.c File src/superio/fintek/f81866d/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/fintek/f81866d/superio.c... PS8, Line 22: #include <pc80/keyboard.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/superio/intel/i8900/superio.c File src/superio/intel/i8900/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/intel/i8900/superio.c@20 PS8, Line 20: #include "i8900.h" move local include down?
https://review.coreboot.org/#/c/32023/8/src/superio/ite/it8671f/superio.c File src/superio/ite/it8671f/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/ite/it8671f/superio.c@20 PS8, Line 20: #include <superio/conf_mode.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/superio/ite/it8721f/superio.c File src/superio/ite/it8721f/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/ite/it8721f/superio.c@21 PS8, Line 21: #include <superio/conf_mode.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87309/superio.c File src/superio/nsc/pc87309/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87309/superio.c@19 PS8, Line 19: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87360/superio.c File src/superio/nsc/pc87360/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87360/superio.c@20 PS8, Line 20: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87366/superio.c File src/superio/nsc/pc87366/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87366/superio.c@20 PS8, Line 20: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87382/superio.c File src/superio/nsc/pc87382/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87382/superio.c@18 PS8, Line 18: #include <device/pnp.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87384/superio.c File src/superio/nsc/pc87384/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87384/superio.c@18 PS8, Line 18: #include <device/pnp.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87392/superio.c File src/superio/nsc/pc87392/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87392/superio.c@18 PS8, Line 18: #include <device/pnp.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87417/superio.c File src/superio/nsc/pc87417/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc87417/superio.c@21 PS8, Line 21: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc97317/superio.c File src/superio/nsc/pc97317/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/nsc/pc97317/superio.c@19 PS8, Line 19: #include <pc80/keyboard.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/superio/nuvoton/nct5104d/superio... File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/nuvoton/nct5104d/superio... PS8, Line 18: #include <superio/conf_mode.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/nuvoton/wpcm450/superio.... File src/superio/nuvoton/wpcm450/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/nuvoton/wpcm450/superio.... PS8, Line 19: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/dme1737/superio.c File src/superio/smsc/dme1737/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/dme1737/superio.c@2... PS8, Line 23: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/kbc1100/superio.c File src/superio/smsc/kbc1100/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/kbc1100/superio.c@2... PS8, Line 22: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47b272/superio.c File src/superio/smsc/lpc47b272/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47b272/superio.c... PS8, Line 26: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47b397/superio.c File src/superio/smsc/lpc47b397/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47b397/superio.c... PS8, Line 24: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47m10x/superio.c File src/superio/smsc/lpc47m10x/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47m10x/superio.c... PS8, Line 25: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47m15x/superio.c File src/superio/smsc/lpc47m15x/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47m15x/superio.c... PS8, Line 22: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47n207/early_ser... File src/superio/smsc/lpc47n207/early_serial.c:
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47n207/early_ser... PS8, Line 18: #include <stdint.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47n217/superio.c File src/superio/smsc/lpc47n217/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/lpc47n217/superio.c... PS8, Line 27: #include <assert.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/mec1308/superio.c File src/superio/smsc/mec1308/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/mec1308/superio.c@2... PS8, Line 22: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/sio10n268/superio.c File src/superio/smsc/sio10n268/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/smsc/sio10n268/superio.c... PS8, Line 18: #include <pc80/keyboard.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/superio/via/vt1211/superio.c File src/superio/via/vt1211/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/via/vt1211/superio.c@21 PS8, Line 21: #include <superio/conf_mode.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83627dhg/superi... File src/superio/winbond/w83627dhg/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83627dhg/superi... PS8, Line 19: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83627ehg/superi... File src/superio/winbond/w83627ehg/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83627ehg/superi... PS8, Line 25: #include <pc80/mc146818rtc.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83627hf/superio... File src/superio/winbond/w83627hf/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83627hf/superio... PS8, Line 25: #include <pc80/mc146818rtc.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83627uhg/superi... File src/superio/winbond/w83627uhg/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83627uhg/superi... PS8, Line 21: #include <pc80/keyboard.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83697hf/superio... File src/superio/winbond/w83697hf/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83697hf/superio... PS8, Line 22: #include <lib.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83977tf/superio... File src/superio/winbond/w83977tf/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/w83977tf/superio... PS8, Line 22: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/wpcd376i/superio... File src/superio/winbond/wpcd376i/superio.c:
https://review.coreboot.org/#/c/32023/8/src/superio/winbond/wpcd376i/superio... PS8, Line 21: #include <pc80/keyboard.h> add extra newline
https://review.coreboot.org/#/c/32023/8/src/vendorcode/cavium/bdk/libbdk-hal... File src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c:
https://review.coreboot.org/#/c/32023/8/src/vendorcode/cavium/bdk/libbdk-hal... PS8, Line 41: #include <string.h> add extra newline?
https://review.coreboot.org/#/c/32023/8/src/vendorcode/cavium/bdk/libbdk-hal... File src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c:
https://review.coreboot.org/#/c/32023/8/src/vendorcode/cavium/bdk/libbdk-hal... PS8, Line 41: #include <stdlib.h> add extra newline?