A bunch of "{add, remove} extra newline are optional and are up to you.
You cann add it to the cimmit message if you decide to modify the newlines if you like.
Patch set 8:Code-Review +1
132 comments:
Patch Set #8, Line 19: #include <stdlib.h>
Try to add includes in an alphabetical order.
File src/commonlib/storage/bouncebuf.c:
#include <string.h>
#include <stdlib.h>
same here
File src/commonlib/storage/sdhci_adma.c:
Patch Set #8, Line 26: #include <stdlib.h>
same here
File src/cpu/x86/lapic/lapic_cpu_init.c:
Patch Set #8, Line 38: #include <stdlib.h>
and here
File src/device/device_util.c:
Patch Set #8, Line 27: #include <stdlib.h>
same
File src/drivers/i2c/tpm/tis_atmel.c:
Patch Set #8, Line 26: #include <stdlib.h>
and here
File src/drivers/spi/spi-generic.c:
Patch Set #8, Line 20: #include <stdlib.h>
and here
File src/mainboard/amd/serengeti_cheetah_fam10/get_bus_conf.c:
Should we get rind of this extra newline?
File src/mainboard/amd/tilapia_fam10/get_bus_conf.c:
delete extra newline
File src/mainboard/amd/torpedo/BiosCallOuts.c:
Patch Set #8, Line 19: #include "Hudson-2.h"
Once touching this file move this include down?
File src/mainboard/amd/union_station/buildOpts.c:
delete these two newlines?
File src/mainboard/asrock/e350m1/buildOpts.c:
One newline should be good enough.
File src/mainboard/asus/m4a78-em/get_bus_conf.c:
delete extra newline?
File src/mainboard/asus/m4a785-m/get_bus_conf.c:
delete extra newline
File src/mainboard/elmex/pcm205400/buildOpts.c:
delete 2 extra newlines here?
File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
Patch Set #8, Line 16: #include <stdlib.h>
Try to add includes in an alphabetical order.
File src/mainboard/gigabyte/ma785gm/get_bus_conf.c:
delete extra newline?
File src/mainboard/gigabyte/ma78gm/get_bus_conf.c:
delete extra newline
File src/mainboard/gizmosphere/gizmo/buildOpts.c:
get rid of extra newlines?
File src/mainboard/google/beltino/variants/mccloud/hda_verb.c:
delete extra newline?
File src/mainboard/google/beltino/variants/monroe/hda_verb.c:
here, too
File src/mainboard/google/beltino/variants/panther/hda_verb.c:
delete extra newline
File src/mainboard/google/beltino/variants/tricky/hda_verb.c:
delete extra newline
File src/mainboard/google/beltino/variants/zako/hda_verb.c:
here, too
File src/mainboard/google/cyan/variants/kefka/gpio.c:
delete extra newline
File src/mainboard/google/cyan/variants/relm/gpio.c:
delete extra newline
File src/mainboard/google/cyan/variants/setzer/gpio.c:
here, too
File src/mainboard/google/urara/boardid.c:
delete extra newline?
File src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c:
delete extra newline?
File src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c:
delete extra newline?
File src/mainboard/intel/kblrvp/mainboard.c:
Patch Set #8, Line 23: #include "ec.h"
move this include to the last position?
File src/mainboard/intel/kunimitsu/mainboard.c:
Patch Set #8, Line 23: #include <vendorcode/google/chromeos/chromeos.h>
add extra newline here?
File src/mainboard/intel/strago/gpio.c:
Patch Set #8, Line 19: #include <boardid.h>
add extra newline here?
File src/mainboard/jetway/nf81-t56n-lf/BiosCallOuts.c:
delete extra newline?
File src/mainboard/jetway/nf81-t56n-lf/buildOpts.c:
delete extra newline?
File src/mainboard/jetway/pa78vm5/get_bus_conf.c:
delete extra newline
File src/mainboard/lenovo/g505s/BiosCallOuts.c:
here, too
File src/mainboard/lenovo/g505s/buildOpts.c:
delete extra newlines
File src/mainboard/lippert/frontrunner-af/buildOpts.c:
delete extra newlines
File src/mainboard/lippert/frontrunner-af/sema.c:
move this newline before local includes?
File src/mainboard/lippert/toucan-af/buildOpts.c:
delete extra newlines
File src/mainboard/msi/ms7721/BiosCallOuts.c:
delete extra newline
File src/mainboard/msi/ms7721/buildOpts.c:
here, too
File src/mainboard/msi/ms9652_fam10/get_bus_conf.c:
delete this newline?
File src/mainboard/pcengines/apu1/BiosCallOuts.c:
Patch Set #8, Line 20: #include "gpio_ftns.h"
add extra newline before local includes.
File src/mainboard/pcengines/apu1/buildOpts.c:
delete extra newlines
File src/mainboard/roda/rk886ex/m3885.c:
move this newline right before local include?
File src/mainboard/supermicro/h8dmr_fam10/get_bus_conf.c:
delete extra newline?
File src/mainboard/supermicro/h8qme_fam10/get_bus_conf.c:
delete extra newline?
File src/mainboard/supermicro/h8scm_fam10/get_bus_conf.c:
delete extra newline?
File src/mainboard/tyan/s2912_fam10/get_bus_conf.c:
delete extra newline
File src/northbridge/amd/agesa/family12/dimmSpd.c:
delete extra newline
File src/northbridge/amd/agesa/family12/northbridge.c:
delete extra newline
File src/northbridge/amd/agesa/family14/dimmSpd.c:
delete extra newline
Patch Set #8, Line 23: #include "chip.h"
move local include to the last position?
File src/northbridge/intel/haswell/early_init.c:
Patch Set #8, Line 23: #include "haswell.h"
add extra newline?
File src/northbridge/intel/haswell/finalize.c:
Patch Set #8, Line 17: #include <device/pci_ops.h>
add extra newline?
File src/northbridge/intel/i440bx/northbridge.c:
Patch Set #8, Line 20: #include <cpu/cpu.h>
add extra newline
File src/northbridge/intel/i440bx/raminit.c:
Patch Set #8, Line 24: #include <console/console.h>
add extra newline
File src/northbridge/intel/i945/early_init.c:
Patch Set #8, Line 24: #include "i945.h
move this local include to the last position?
File src/northbridge/intel/i945/northbridge.c:
Patch Set #8, Line 25: #include <cpu/intel/smm/gen1/smi.h>
add extra newline
File src/northbridge/intel/nehalem/finalize.c:
Patch Set #8, Line 17: #include <device/pci_ops.h>
add extra newline?
File src/northbridge/intel/nehalem/northbridge.c:
#include "chip.h"
#include "nehalem.h"
once touching it move local includes down?
File src/northbridge/intel/sandybridge/finalize.c:
Patch Set #8, Line 17: #include <device/pci_ops.h>
add extra newline
File src/northbridge/intel/sandybridge/northbridge.c:
#include "chip.h"
#include "sandybridge.h"
move local includes down?
File src/security/tpm/tss/tcg-2.0/tss_marshaling.c:
Patch Set #8, Line 12: #include "tss_marshaling.h"
move local include down?
File src/soc/amd/stoneyridge/BiosCallOuts.c:
Patch Set #8, Line 26: #include "chip.h"
move local include down and adjust newlines?
File src/soc/intel/baytrail/ramstage.c:
delete extra newline
File src/soc/intel/common/acpi_wake_source.c:
Patch Set #8, Line 21: #include <stdint.h>
add extra newline
File src/soc/intel/common/smbios.c:
Patch Set #8, Line 17: #include "smbios.h"
move local include down?
File src/soc/intel/denverton_ns/systemagent.c:
delete extra newline
File src/soc/intel/fsp_baytrail/ramstage.c:
delete extra newline
File src/soc/intel/fsp_baytrail/smihandler.c:
delete extra newline
File src/soc/nvidia/tegra/i2c.c:
Patch Set #8, Line 21: #include <soc/addressmap.h>
add extra newline
File src/soc/nvidia/tegra210/dc.c:
Patch Set #8, Line 21: #include "chip.h"
move local include down?
File src/soc/nvidia/tegra210/dsi.c:
Patch Set #8, Line 26: #include "chip.h"
move local include down?
File src/soc/nvidia/tegra210/jdi_25x18_display/panel-jdi-lpm102a188a.c:
Patch Set #8, Line 22: #include "../chip.h"
move local include down?
Patch Set #8, Line 25: #include <soc/tegra_dsi.h>
add extra newline
File src/soc/nvidia/tegra210/mipi.c:
Patch Set #8, Line 27: #include <soc/tegra_dsi.h>
add extra newline?
File src/southbridge/amd/agesa/hudson/sm.c:
Patch Set #8, Line 22: #include <arch/ioapic.h>
add extra newlines
File src/southbridge/amd/agesa/hudson/spi.c:
delete extra newline
File src/southbridge/amd/cimx/sb800/spi.c:
Patch Set #8, Line 24: #include "SBPLATFORM.h"
move local include down?
File src/southbridge/amd/pi/hudson/sm.c:
Patch Set #8, Line 22: #include <arch/ioapic.h>
add extra newline
File src/southbridge/amd/sb700/sm.c:
Patch Set #8, Line 26: #include <arch/ioapic.h>
add extra newline
File src/southbridge/amd/sb800/sm.c:
Patch Set #8, Line 25: #include <arch/ioapic.h>
add extra newline
File src/southbridge/intel/bd82x6x/me_status.c:
Patch Set #8, Line 17: #include <console/console.h>
add extra newline
File src/southbridge/intel/common/smbus.c:
Patch Set #8, Line 20: #include <device/smbus_def.h>
add extra newline
File src/southbridge/intel/fsp_rangeley/early_init.c:
Patch Set #8, Line 25: #include <version.h>
add extra newline?
File src/southbridge/intel/i82801ix/i82801ix.c:
Patch Set #8, Line 23: #include <console/console.h>
add extra newline?
File src/southbridge/intel/i82801jx/i82801jx.c:
Patch Set #8, Line 23: #include <console/console.h>
add extra newline?
File src/southbridge/intel/lynxpoint/me_status.c:
Patch Set #8, Line 17: #include <console/console.h>
add extra newline?
File src/southbridge/intel/lynxpoint/serialio.c:
Patch Set #8, Line 23: #include <device/pci_ids.h>
add extra newline
File src/southbridge/nvidia/ck804/lpc.c:
Patch Set #8, Line 33: #include <cpu/amd/powernow.h>
add extra newline
File src/southbridge/nvidia/mcp55/lpc.c:
Patch Set #8, Line 34: #include <cpu/amd/powernow.h>
add extra newline?
File src/superio/fintek/f71805f/superio.c:
Patch Set #8, Line 19: #include <superio/conf_mode.h>
add extra newline
File src/superio/fintek/f71863fg/superio.c:
Patch Set #8, Line 20: #include <pc80/keyboard.h>
add extra newline
File src/superio/fintek/f71872/superio.c:
Patch Set #8, Line 20: #include <pc80/keyboard.h>
add extra newline
File src/superio/fintek/f81865f/superio.c:
Patch Set #8, Line 20: #include <pc80/keyboard.h>
add extra newline?
File src/superio/fintek/f81866d/superio.c:
Patch Set #8, Line 22: #include <pc80/keyboard.h>
add extra newline?
File src/superio/intel/i8900/superio.c:
Patch Set #8, Line 20: #include "i8900.h"
move local include down?
File src/superio/ite/it8671f/superio.c:
Patch Set #8, Line 20: #include <superio/conf_mode.h>
add extra newline?
File src/superio/ite/it8721f/superio.c:
Patch Set #8, Line 21: #include <superio/conf_mode.h>
add extra newline?
File src/superio/nsc/pc87309/superio.c:
Patch Set #8, Line 19: #include <pc80/keyboard.h>
add extra newline
File src/superio/nsc/pc87360/superio.c:
Patch Set #8, Line 20: #include <pc80/keyboard.h>
add extra newline
File src/superio/nsc/pc87366/superio.c:
Patch Set #8, Line 20: #include <pc80/keyboard.h>
add extra newline
File src/superio/nsc/pc87382/superio.c:
Patch Set #8, Line 18: #include <device/pnp.h>
add extra newline
File src/superio/nsc/pc87384/superio.c:
Patch Set #8, Line 18: #include <device/pnp.h>
add extra newline
File src/superio/nsc/pc87392/superio.c:
Patch Set #8, Line 18: #include <device/pnp.h>
add extra newline
File src/superio/nsc/pc87417/superio.c:
Patch Set #8, Line 21: #include <pc80/keyboard.h>
add extra newline
File src/superio/nsc/pc97317/superio.c:
Patch Set #8, Line 19: #include <pc80/keyboard.h>
add extra newline?
File src/superio/nuvoton/nct5104d/superio.c:
Patch Set #8, Line 18: #include <superio/conf_mode.h>
add extra newline
File src/superio/nuvoton/wpcm450/superio.c:
Patch Set #8, Line 19: #include <pc80/keyboard.h>
add extra newline
File src/superio/smsc/dme1737/superio.c:
Patch Set #8, Line 23: #include <pc80/keyboard.h>
add extra newline
File src/superio/smsc/kbc1100/superio.c:
Patch Set #8, Line 22: #include <pc80/keyboard.h>
add extra newline
File src/superio/smsc/lpc47b272/superio.c:
Patch Set #8, Line 26: #include <pc80/keyboard.h>
add extra newline
File src/superio/smsc/lpc47b397/superio.c:
Patch Set #8, Line 24: #include <pc80/keyboard.h>
add extra newline
File src/superio/smsc/lpc47m10x/superio.c:
Patch Set #8, Line 25: #include <pc80/keyboard.h>
add extra newline
File src/superio/smsc/lpc47m15x/superio.c:
Patch Set #8, Line 22: #include <pc80/keyboard.h>
add extra newline
File src/superio/smsc/lpc47n207/early_serial.c:
Patch Set #8, Line 18: #include <stdint.h>
add extra newline
File src/superio/smsc/lpc47n217/superio.c:
Patch Set #8, Line 27: #include <assert.h>
add extra newline
File src/superio/smsc/mec1308/superio.c:
Patch Set #8, Line 22: #include <pc80/keyboard.h>
add extra newline
File src/superio/smsc/sio10n268/superio.c:
Patch Set #8, Line 18: #include <pc80/keyboard.h>
add extra newline?
File src/superio/via/vt1211/superio.c:
Patch Set #8, Line 21: #include <superio/conf_mode.h>
add extra newline
File src/superio/winbond/w83627dhg/superio.c:
Patch Set #8, Line 19: #include <pc80/keyboard.h>
add extra newline
File src/superio/winbond/w83627ehg/superio.c:
Patch Set #8, Line 25: #include <pc80/mc146818rtc.h>
add extra newline
File src/superio/winbond/w83627hf/superio.c:
Patch Set #8, Line 25: #include <pc80/mc146818rtc.h>
add extra newline
File src/superio/winbond/w83627uhg/superio.c:
Patch Set #8, Line 21: #include <pc80/keyboard.h>
add extra newline?
File src/superio/winbond/w83697hf/superio.c:
Patch Set #8, Line 22: #include <lib.h>
add extra newline
File src/superio/winbond/w83977tf/superio.c:
Patch Set #8, Line 22: #include <pc80/keyboard.h>
add extra newline
File src/superio/winbond/wpcd376i/superio.c:
Patch Set #8, Line 21: #include <pc80/keyboard.h>
add extra newline
File src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c:
Patch Set #8, Line 41: #include <string.h>
add extra newline?
File src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c:
Patch Set #8, Line 41: #include <stdlib.h>
add extra newline?
To view, visit change 32023. To unsubscribe, or for help writing mail filters, visit settings.