Boon Tiong Teo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34166 )
Change subject: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation ......................................................................
Patch Set 1:
Patch Set 1:
Hi Nico, we are alright to remove FSP CAR as default, and we already included steps on enabling FSP-T in our communication with customers.
Thank you.
Thanks for bringing up the error you faced, we will also work to include FSP-T enabling details in documentation including 'CPU_MICROCODE_CBFS_LEN'and 'CPU_MICROCODE_CBFS_LOC' where you got into a brick, so anyone in this community will understand the technicality behind enabling FSP-T CAR.
I think the time would be better spent to enhance coreboot's CAR implementation to the point that nobody needs FSP-T. AFAIK, nobody in the open-source community wants it anyway. Why do you or your customers need FSP-T?
Agreed on we should have a default option not to use FspT, but not agreed on remove it as really there is customer from IOT who need that it. Please give us sometime to work with program level on this open issue, then we can propose a better solution for it. Thanks.