[coreboot-gerrit] Change in coreboot[master]: drivers/ocp/ipmi: Add ipmi POST start/end command

[Johnny Lin (Code Review)]

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41605 )

Change subject: drivers/ocp/ipmi: Add ipmi POST start/end command
......................................................................

Patch Set 4:
> Patch Set 4: -Code-Review
>
> With this design, POST start/end IPMI commands are sent during ramstage, when the IPMI_OCP device is initialized and finalized.
>
> Ideally the behavior should be similar to traditional firmware,I think:
> POST start IPMI command should be sent as early as possible, in romstage when IPMI communication is established.
> POST end IPMI command should be sent as late as possible, either in ramstage just before control is given to payload, or in Linuxboot uinit just before control is given to target OS.

Another option is to similar to CB:38002, make the functions with kcs_port parameter that can be called from mainboard romstage and ramstage, ex:
void supermicro_ipmi_oem(const uint16_t kcs_port);