Keith Short has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32773 )
Change subject: coreboot: add post code for memory error from FSP ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32773/2/src/drivers/intel/fsp1_1/raminit.c File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/#/c/32773/2/src/drivers/intel/fsp1_1/raminit.c@2... PS2, Line 201: post_code(POST_INVALID_FSP); : die("ERROR - HOB pointer is NULL!\n");
Unrelated to your change, but shouldn't this check be outside of the config check? We use hob_list_ […]
Looks like the uses of hob_list_ptr outside of this block all have NULL checks. However, the print_hob_type_structure() doesn't appear to have proper NULL checks. I'll move the NULL check around that call only and not call die().