Attention is currently required from: Nico Huber, Krishna Prabhakaran, Maulik V Vaghela, Selma Bensaid, Subrata Banik, Meera Ravindranath, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 )
Change subject: drivers/intel/gma: Support IGD Opregion 2.1 ......................................................................
Patch Set 13:
(1 comment)
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/52758/comment/e5c83c0c_f0aa8007 PS13, Line 105: INTEL_GMA_OPREGION_2_0
I believe that we would need support for 2.0 since all the earlier platforms like cml,jsl and tgl uses 2.0.
What determines this support? Isn't this just something that the kernel driver needs to support? Or are there other factors? If it is just the kernel driver dependency, would it make sense to announce this deprecation in coreboot and drop support for 2.0 in next 6-12 months?
However, we can make 2.1 as default but we would need a change in soc kconfigs of all earlier platforms. Would that be recommended? Only adl uses 2.1 as of now and one kconfig change would suffice.
Yes, one Kconfig change would suffice for now, but what I have been thinking is:
* What is the direction that we are moving in w.r.t. opregion support in coreboot? Do we intend to keep supporting multiple versions forever or would we be moving to newer versions and deprecate older versions at some point?
* If there are some platforms that cannot absolutely move to newer opregion support, then we can keep multiple versions supported and only the older platforms have to select the non-default version (which should ideally be a small subset).
We don't have to address all these within this CL, but having an understanding of the direction we will be taking would be helpful.