Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47659 )
Change subject: soc/intel/common/fast_spi: Add custom boot media device ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/... PS9, Line 25: mmap_boot mmap_boot.c sounds very generic but ends up being tied to this new config option, you might consider naming it something more specific.
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/... PS9, Line 35: check-fmap-16mib-crossing this seems like it could be done easier in fmaptool? but it would probably need to be behind an argument which is harder to isolate to this makefile unless you add something like FMAPTOOL_ADD_CMD_OPTIONS
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/mmap_boot.c:
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/... PS9, Line 103: CONFIG_EXT_BIOS_WIN_BASE could these be checked at compile time?