Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43971 )
Change subject: nb/intel/*: Fill in SMBIOS type 16 on SNB/HSW
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43971/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/43971/1/src/northbridge/intel/sandy...
PS1, Line 59: switch (capid0_a_ddrsz) {
nit: I didn't check if this field from CAPID0_A was redefined between SNB and IVB. I'll check.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43971
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e2346de1ffe52e8685276acbdbf25755f4cc162
Gerrit-Change-Number: 43971
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 08:09:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment