Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42079 )
Change subject: soc/intel/tigerlake: Add code for early tcss ......................................................................
Patch Set 12:
(6 comments)
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... PS12, Line 30: nit: extra blank line
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... PS12, Line 52: nit: extra blank line
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... PS12, Line 201: static void update_tcss_mux(int port, struct tcss_mux mux_data) May be better to pass `mux_data` by reference, i.e., `const struct tcss_mux *mux_data`, to avoid copying
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... PS12, Line 203: struct pmc_ipc_buffer *rbuf = malloc(sizeof(*rbuf)); Does you really need malloc here? It doesn't appear that `rbuf` has a lifetime that is longer than this function, so I think you can just do `struct pmc_ipc_buffer rbuf` here
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/ea... PS12, Line 269: //Add check for connected maybe? ?
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/fs... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42079/12/src/soc/intel/tigerlake/fs... PS12, Line 334: DSK what is DSK?