6 comments:
File src/soc/intel/tigerlake/early_tcss.c:
nit: extra blank line
nit: extra blank line
Patch Set #12, Line 201: static void update_tcss_mux(int port, struct tcss_mux mux_data)
May be better to pass `mux_data` by reference, i.e., `const struct tcss_mux *mux_data`, to avoid copying
Patch Set #12, Line 203: struct pmc_ipc_buffer *rbuf = malloc(sizeof(*rbuf));
Does you really need malloc here? It doesn't appear that `rbuf` has a lifetime that is longer than this function, so I think you can just do `struct pmc_ipc_buffer rbuf` here
Patch Set #12, Line 269: //Add check for connected maybe?
?
File src/soc/intel/tigerlake/fsp_params.c:
what is DSK?
To view, visit change 42079. To unsubscribe, or for help writing mail filters, visit settings.