Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48201 )
Change subject: Makefile.inc: Fix empty output when processing C struct files in CBFS
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48201/5/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48201/5/Makefile.inc@336
PS5, Line 336: <
Yes.
So maybe just use $(1) instead? It may be more clear than $@ and $< given the order was reversed in the rule.
https://review.coreboot.org/c/coreboot/+/48201/5/Makefile.inc@336
PS5, Line 336:
Can't say that I follow. […]
I agree with Nico - having a space before \n is usually considered as wrong. Yes it may be ugly but that's how printf and debug messages already look like. So I'd also recommend removing the extra space.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48201
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6a66e25d7dfe8fe6410e517593ed22a438d2f82
Gerrit-Change-Number: 48201
Gerrit-PatchSet: 5
Gerrit-Owner: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 09 Dec 2020 01:46:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xi Chen
xixi.chen@mediatek.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment