Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33985 )
Change subject: include/cpu/x86: Add STM Support ......................................................................
Patch Set 17:
This patch breaks our Apollo Lake boards in SMM relocation. Here is the part of the console log: ... POST: 0x93 Setting up local APIC... apic_id: 0x00 done. Detected 2 core, 2 thread CPU. Will perform SMM setup. FMAP: area COREBOOT found @ 305000 (11853824 bytes) CBFS @ 305000 size b4e000 CBFS @ 305000 size b4e000 CBFS: 'IAFW Locator' located CBFS at [305000:e53000) CBFS: Locating 'cpu_microcode_blob.bin' CBFS: 'cpu_microcode_blob.bin' not found. CPU: Intel(R) Atom(TM) Processor E3930 @ 1.30GHz. Loading module at 0x00030000 with entry 0x00030000. filesize: 0x170 memsize: 0x170 Processing 16 relocs. Offset value of 0x00030000 Attempting to start 1 APs Waiting for 10ms after sending INIT. Waiting for 1st SIPI to complete...done. AP: slot 1 apic_id 4. Waiting for 2nd SIPI to complete...done. Loading module at 0x00038000 with entry 0x00038000. filesize: 0x1a8 memsize: 0x1a8 Processing 13 relocs. Offset value of 0x00038000 SMM Module: stub loaded at 0x00038000. Will call 0x3ab55390(0x00000000) Installing SMM handler to 0x3b000000 Loading module at 0x3b010000 with entry 0x3b01100a. filesize: 0x3fd0 memsize: 0x7ff0 Processing 377 relocs. Offset value of 0x3b010000 Loading module at 0x3b008000 with entry 0x3b008000. filesize: 0x1a8 memsize: 0x1a8 Processing 13 relocs. Offset value of 0x3b008000 SMM Module: placing jmp sequence at 0x3b007c00 rel16 0x03fd SMM Module: stub loaded at 0x3b008000. Will call 0x3b01100a(0x00000000) Clearing SMI status registers PM1_STS: WAK TCO_STS: SECOND_TO <<-- Here the mainboards die!!!