Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37483 )
Change subject: mb/gigabyte/ga-h61m-s2pv: Add ga-h61m-ds2v as a variant
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37483/4/src/mainboard/gigabyte/ga-h...
File src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/37483/4/src/mainboard/gigabyte/ga-h...
PS4, Line 10: select NO_UART_ON_SUPERIO
It's rather unusual, but it keeps Kconfig cleaner
This is a very old discussion, but I'm not sure that we should split options between files like that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37483
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I467f586530e4a3b53a24b66565b5dcab5e33cf46
Gerrit-Change-Number: 37483
Gerrit-PatchSet: 7
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 07 Mar 2020 17:52:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment