Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39699 )
Change subject: drivers/pc80/tpm/tis.c: change the _HID and _CID for TPM2 device
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39699/1/src/drivers/pc80/tpm/tis.c
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/39699/1/src/drivers/pc80/tpm/tis.c@...
PS1, Line 900: acpigen_write_name_string("_HID", "MSFT0101");
The detail here is the ", or" at the end of b. […]
Right, I missed that or and assumed all 3 conditions must be met. Will test with MSFT0101 CID only.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39699
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45123f272038e664b834cabd9d8525baca0eb583
Gerrit-Change-Number: 39699
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Fri, 20 Mar 2020 21:08:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment