Attention is currently required from: Felix Singer, Nick Vaccaro.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79960?usp=email )
Change subject: intel tgl mainboards: Move PcieRpEnable option below dt entries ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/volteer/variants/voema/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79960/comment/ae431560_42d301ec : PS1, Line 103: device ref pcie_rp7 off : register "PcieRpEnable[6]" = "0" : end I assume this entry will go away once the PcieRpEnable is tied to the dt device status?
https://review.coreboot.org/c/coreboot/+/79960/comment/c3e608e5_2e0a85c0 : PS1, Line 108: probe DB_SD SD_GL9755S : probe DB_SD SD_RTS5261 : probe DB_SD SD_RTS5227S : probe DB_SD SD_GL9750 : probe DB_SD SD_OZ711LV2LN why are you adding probe entries to a device that is off?