Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46472 )
Change subject: mb/google/zork: update telemetry settings for morphius
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46472/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46472/2//COMMIT_MSG@9
PS2, Line 9: update telemetry to improve the performance.
Maybe more specific:
Decrease telemetry voltage slope values …
https://review.coreboot.org/c/coreboot/+/46472/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/morphius/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46472/2/src/mainboard/google/zork/v...
PS2, Line 19: telemetry_vddcr_vdd_slope
The unit should be part of the variable name.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46472
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6c4f1a92d7f2ad293df7b63694e9665b85f8018
Gerrit-Change-Number: 46472
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Edward Hill
ecgh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 19 Oct 2020 15:04:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment