Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37576 )
Change subject: mainboard/(i945,ich7): Remove commented RCBA32(0x341c) code
......................................................................
Patch Set 2:
All the other bits are configured in ramstage (i82801gx/lpc.c), so I
_think_ it wouldn't make a difference to remove the remaining mainboard/
writes. But that should be a separate change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37576
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica38529dbdd5cc51b19b426999a1d9f0b678b4f5
Gerrit-Change-Number: 37576
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 08 Dec 2019 10:52:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment