[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge: Remove unnecessary comments

[Angel Pons (Code Review)]

Hello  Felix Singer, Nico Huber, Arthur Heymans, Patrick Rudolph,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/48401

to review the following change.

Change subject: nb/intel/sandybridge: Remove unnecessary comments
......................................................................

nb/intel/sandybridge: Remove unnecessary comments

These comments were helpful before the massive IOSAV refactoring, but
they are no longer needed since the function names are clear enough.

Change-Id: Ieb9bdf3f7fc72f63a8978f2b98e0bc8228c55868
Signed-off-by: Angel Pons 
---
M src/northbridge/intel/sandybridge/raminit_common.c
1 file changed, 1 insertion(+), 29 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/48401/1

diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c
index 612d25c..d459632 100644
--- a/src/northbridge/intel/sandybridge/raminit_common.c
+++ b/src/northbridge/intel/sandybridge/raminit_common.c
@@ -546,11 +546,7 @@

iosav_write_zqcs_sequence(channel, slotrank, 3, 8, 0);

-	/*
-	 * Execute command queue - why is bit 22 set here?!
-	 *
-	 * This is actually using the IOSAV state machine as a timer, so refresh is allowed.
-	 */
+	/* This is actually using the IOSAV state machine as a timer */
    iosav_run_queue(channel, 1, 1);

wait_for_iosav(channel);
@@ -684,7 +680,6 @@
    };
    iosav_write_sequence(channel, sequence, ARRAY_SIZE(sequence));

-	/* Execute command queue */
    iosav_run_once(channel);
 }

@@ -896,11 +891,9 @@
    };
    iosav_write_sequence(BROADCAST_CH, zqcl_sequence, ARRAY_SIZE(zqcl_sequence));

-	/* Execute command queue on all channels. Do it four times. */
    iosav_run_queue(BROADCAST_CH, 4, 0);

FOR_ALL_CHANNELS {
-		/* Wait for ref drained */
    	wait_for_iosav(channel);
    }

@@ -914,15 +907,12 @@

slotrank = (ctrl->rankmap[channel] & 1) ? 0 : 2;

-		/* Drain */
    	wait_for_iosav(channel);

iosav_write_zqcs_sequence(channel, slotrank, 4, 101, 31);

-		/* Execute command queue */
    	iosav_run_once(channel);

-		/* Drain */
    	wait_for_iosav(channel);
    }
 }
@@ -1063,7 +1053,6 @@
    /* Send a burst of 16 back-to-back read commands (4 DCLK apart) */
    iosav_write_read_mpr_sequence(channel, slotrank, ctrl->tMOD, 1, 3, 15, ctrl->CAS + 36);

-	/* Execute command queue */
    iosav_run_once(channel);

wait_for_iosav(channel);
@@ -1348,7 +1337,6 @@

iosav_write_prea_sequence(channel, slotrank, ctrl->tRP, 0);

-		/* Execute command queue */
    	iosav_run_once(channel);

const union gdcr_training_mod_reg training_mod = {
@@ -1441,14 +1429,12 @@
    iosav_write_misc_write_sequence(ctrl, channel, slotrank,
    	MAX(ctrl->tRRD, (ctrl->tFAW >> 2) + 1), 4, 4, 500, 18);

-	/* Execute command queue */
    iosav_run_once(channel);

wait_for_iosav(channel);

iosav_write_prea_act_read_sequence(ctrl, channel, slotrank);

-	/* Execute command queue */
    iosav_run_once(channel);

wait_for_iosav(channel);
@@ -1483,7 +1469,6 @@

iosav_write_prea_sequence(channel, slotrank, ctrl->tRP, 18);

-	/* Execute command queue */
    iosav_run_once(channel);

for (tx_dq = 0; tx_dq <= MAX_TX_DQ; tx_dq++) {
@@ -1606,7 +1591,6 @@
    	}
    	program_timings(ctrl, channel);

-		/* Execute command queue */
    	iosav_run_once(channel);

wait_for_iosav(channel);
@@ -1687,7 +1671,6 @@

iosav_write_misc_write_sequence(ctrl, channel, slotrank, 3, 1, 3, 3, 31);

-		/* Execute command queue */
    	iosav_run_once(channel);

wait_for_iosav(channel);
@@ -1758,7 +1741,6 @@
    	};
    	iosav_write_sequence(channel, rd_sequence, ARRAY_SIZE(rd_sequence));

-		/* Execute command queue */
    	iosav_run_once(channel);

wait_for_iosav(channel);
@@ -1789,7 +1771,6 @@

iosav_write_zqcs_sequence(channel, slotrank, 4, 4, 31);

-		/* Execute command queue */
    	iosav_run_once(channel);

wait_for_iosav(channel);
@@ -1870,7 +1851,6 @@

iosav_write_zqcs_sequence(channel, 0, 4, 101, 31);

-		/* Execute command queue */
    	iosav_run_once(channel);

wait_for_iosav(channel);
@@ -1948,7 +1928,6 @@
    	MCHBAR32(IOSAV_n_ADDRESS_LFSR_ch(channel, 1)) = 0x389abcd;
    	MCHBAR32(IOSAV_n_ADDRESS_LFSR_ch(channel, 2)) = 0x389abcd;

-		/* Execute command queue */
    	iosav_run_once(channel);

wait_for_iosav(channel);
@@ -2162,7 +2141,6 @@
    	iosav_write_read_mpr_sequence(
    		channel, slotrank, ctrl->tMOD, 500, 4, 1, ctrl->CAS + 8);

-		/* Execute command queue */
    	iosav_run_once(channel);

wait_for_iosav(channel);
@@ -2209,7 +2187,6 @@
    	iosav_write_read_mpr_sequence(
    		channel, slotrank, ctrl->tMOD, 3, 4, 1, ctrl->CAS + 8);

-		/* Execute command queue */
    	iosav_run_once(channel);

wait_for_iosav(channel);
@@ -2230,7 +2207,6 @@
    	iosav_write_read_mpr_sequence(
    		channel, slotrank, ctrl->tMOD, 3, 4, 1, ctrl->CAS + 8);

-		/* Execute command queue */
    	iosav_run_once(channel);

wait_for_iosav(channel);
@@ -2346,7 +2322,6 @@

iosav_write_data_write_sequence(ctrl, channel, slotrank);

-				/* Execute command queue */
    			iosav_run_once(channel);

wait_for_iosav(channel);
@@ -2444,7 +2419,6 @@

iosav_write_aggressive_write_read_sequence(ctrl, channel, slotrank);

-	/* Execute command queue */
    iosav_run_once(channel);

wait_for_iosav(channel);
@@ -2626,7 +2600,6 @@

iosav_write_memory_test_sequence(ctrl, channel, slotrank);

-		/* Execute command queue */
    	iosav_run_once(channel);

wait_for_iosav(channel);
@@ -2749,7 +2722,6 @@
    			};
    			iosav_write_sequence(channel, sequence, ARRAY_SIZE(sequence));

-				/* Execute command queue */
    			iosav_run_queue(channel, 16, 0);

wait_for_iosav(channel);