Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43971 )
Change subject: nb/intel/*: Fill in SMBIOS type 16 on SNB/HSW ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/43971/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43971/1//COMMIT_MSG@7 PS1, Line 7: SND
SNB
Done
https://review.coreboot.org/c/coreboot/+/43971/1//COMMIT_MSG@9 PS1, Line 9: CAPID_A
CAPID0_A
Done
https://review.coreboot.org/c/coreboot/+/43971/1/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/raminit.c:
https://review.coreboot.org/c/coreboot/+/43971/1/src/northbridge/intel/haswe... PS1, Line 173: soc_systemagent_max_chan_capacity_mib
Can we call this `northbridge_max_chan_capacity_mib` instead, please? This is not a SoC
Done
https://review.coreboot.org/c/coreboot/+/43971/1/src/northbridge/intel/haswe... PS1, Line 238: pci_read_config32
needs pci_ops. […]
Done
https://review.coreboot.org/c/coreboot/+/43971/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/43971/1/src/northbridge/intel/sandy... PS1, Line 80:
two spaces
Done
https://review.coreboot.org/c/coreboot/+/43971/1/src/northbridge/intel/sandy... PS1, Line 82: (!(capida & CAPID_PDCD) + 1)
Why not encapsulate these too, like on soc/intel?
Done