Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )
Change subject: mainboard/lenovo/t430s: Add ThinkPad T431s as a variant ......................................................................
Patch Set 8:
(4 comments)
Do you want to add a data.vbt file ?
https://review.coreboot.org/#/c/30021/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30021/8//COMMIT_MSG@38 PS8, Line 38: - Detecting the model of Soldered RAM at runtime, and loading the That should be mentioned in the Documentation !
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/hda_verb.... File src/mainboard/lenovo/t430s/hda_verb.c:
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/hda_verb.... PS8, Line 16: no need to keep the empty file
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... File src/mainboard/lenovo/t430s/variants/t431s/romstage.c:
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... PS8, Line 37: pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0x0c06a1); seems to be same as on t430, why duplicate it ?
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... File src/mainboard/lenovo/t430s/variants/t431s/smihandler.c:
https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/... PS8, Line 25: /* Enable 0x1600/0x1600 register pair */ the whole file should be removed. The bit can be set by ec/lenovo/h8/h8.c using devicetree values.