Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29478 )
Change subject: device/i2c_bus: Add i2c_dev_readb_at_word() ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/29478/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/29478/8//COMMIT_MSG@10 PS8, Line 10: chip (for larger EEPROM parts). not true (anymore?)
https://review.coreboot.org/c/coreboot/+/29478/8/src/include/device/i2c_bus.... File src/include/device/i2c_bus.h:
https://review.coreboot.org/c/coreboot/+/29478/8/src/include/device/i2c_bus.... PS8, Line 99: uint8_t *buf, size_t len, uint16_t off); Not sure how it happened, but this signature, the function name and the commit message are out of sync.
As this function doesn't read a single byte but a string of bytes, it should be named
i2c_dev_read_at_word
or maybe
i2c_dev_read_at16
?