View Change

2 comments:

• Commit Message:

  • Patch Set #8, Line 10: chip (for larger EEPROM parts).

    not true (anymore?)

• File src/include/device/i2c_bus.h:

  • Patch Set #8, Line 99: uint8_t *buf, size_t len, uint16_t off);

    Not sure how it happened, but this signature, the function name and the
    commit message are out of sync.

    As this function doesn't read a single byte but a string of bytes, it
    should be named

        i2c_dev_read_at_word

    or maybe

        i2c_dev_read_at16

    ?

To view, visit change 29478. To unsubscribe, or for help writing mail filters, visit settings.