Attention is currently required from: Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe RC driver in Coreboot ......................................................................
Patch Set 3:
(26 comments)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/647161b6_0c31c287 PS3, Line 68: #define PCIE1_MEM_SIZE 0x1fd00000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/748d273b_12e81fb5 PS3, Line 69: #define PCIE_MEM_END 0x404fffff please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/1f34611c_34837b3f PS3, Line 72: #define PCIE_1_QMP_PHY 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/bb8d76ca_f4d40317 PS3, Line 76: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/pcie.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/30bc044e_5ba971f4 PS3, Line 18: #define DEV_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/57dd36c7_dc97a3e8 PS3, Line 19: #define CLASS_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/6ea3698a_f54c7a71 PS3, Line 20: #define HEADER_SZ 8 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/d2efe71b_8e193238 PS3, Line 21: #define VEND_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/c47b78df_bd81dc28 PS3, Line 25: #define PCIE_CLASS 0x0a please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/a4f62aa8_a57344ef PS3, Line 26: #define PCI_MAX_DEV_FN 0x100 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/7fb3e268_4f23efca PS3, Line 41: #define PCIE1_3x2_NUM_LANES 2 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/119c0440_48f13961 PS3, Line 57: #define PERST_DELAY_US 1000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/ebd54c68_3581b386 PS3, Line 58: #define PCIE_MAX_BARS 6 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/926ddbec_90a26083 PS3, Line 154: #define PCIE1_QMP_PHY_PCS_COM 0x01C0EA00 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/07f4acbb_5f735916 PS3, Line 155: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/6c7841d2_b5b20236 PS3, Line 156: #define PCE1_QPHY_TX0 0x01C0E200 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/cf7cd63d_453b6605 PS3, Line 157: #define PCE1_QPHY_RX0 0x01C0E400 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/9dcada9d_a58e70f9 PS3, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/5c898cd2_47044130 PS3, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/99d7a657_dea3efe6 PS3, Line 188: #define PCIE_DEV(_bus, _dev, _fn) (0x80000000 | \ Macros with complex values should be enclosed in parentheses
File src/soc/qualcomm/sc7280/pcie_host.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/8a3ed71f_186a911f PS3, Line 303: pci_ep_cfg_info.config_base = (void*)PCIE1_GEN3x2_CONF; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/fe2fcf71_36d65959 PS3, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/bcc6581f_b4b5b89b PS3, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/77acf95e_7571f1c3 PS3, Line 468: printk(BIOS_NOTICE,"pcie ep PERST desserted\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/7127753f_bc64ff65 PS3, Line 773: if (vend_id == 0xffff || vend_id == 0x0000) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119134): https://review.coreboot.org/c/coreboot/+/53902/comment/30c66931_6b403093 PS3, Line 1140: if(!ret) space required before the open parenthesis '('