Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44708 )
Change subject: soc/mediatek/mt8192: Update initial settings of dramc ......................................................................
Patch Set 43:
(9 comments)
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... PS43, Line 3089: u8 dq_hyst_sel = 0x1, ca_hyst_sel = 0x1; : u8 dq_cap_sel = 0x18, ca_cap_sel = 0x18; No need to initialize these.
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... PS43, Line 3537: UI lowercase
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... PS43, Line 3569: u32 const u32
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... PS43, Line 3583: u8 ca_pi = 0, ca_ui = 1; const
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... PS43, Line 3593: C "c" for consistency
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... PS43, Line 3632: 0 Define a variable for this.
u8 something; if (freq_group <= ...) something = 0; else if (freq_group <= ...) something = 1; else something = 2; SET32_BITFIELDS(&ch[0].phy_ao.misc_shu_phy_rx_ctrl, MISC_SHU_PHY_RX_CTRL_RX_IN_BUFF_EN_HEAD, something);
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... PS43, Line 177: = {0} No need to initialize it.
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... PS43, Line 185: &ch[0].phy_ao Please define a local variable for this.
https://review.coreboot.org/c/coreboot/+/44708/43/src/soc/mediatek/mt8192/dr... PS43, Line 229: Error from built bot:
Check that files end with a single newline (lint-extended-015-final-newlines): src/soc/mediatek/mt8192/dramc_pi_calibration_api.c has multiple final newlines.